[RFC] Adding sliding window support (i.e. local attention) to Example 77 #2680
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 1908dd8.
|
maybe @hwu36? Would love to get some feedback |
|
This PR has been labeled |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, trying to a review and some suggestions for further perf improvements.
tldr: Adding sliding window support. We can now pass in window_size_left and window_size_right to Example 77 FMHA.
For the most part, the implementation is pretty standard. In forward, when handling the mask -> unmask -> mask pattern, we adopt the dynamic dispatch mechanism, copied from the backward masking dynamic dispatch mechanism, instead of a 2-loop / 3-loop mechanism.
Features:
Does not support: